fix(common): Don't render backendRefs with RequestRedirect in GW API routes #391
+24
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christopher Larivière <[email protected]>
larivierec
force-pushed
the
fix-backendrefs-render
branch
from
967dfda to
8f4db54
Compare
lehmanju
reviewed
Mar 11, 2025
| name: {{ default .name $service.name }} | ||
| namespace: {{ default $rootContext.Release.Namespace .namespace }} | ||
| port: {{ default .port $servicePrimaryPort.port }} | ||
| weight: {{ include "bjw-s.common.lib.defaultKeepNonNullValue" (dict "value" .weight "default" 1) }} | ||
| {{- end }} | ||
| {{- if or (eq $routeKind "HTTPRoute") (eq $routeKind "GRPCRoute") }} | ||
| {{- with .matches }} | ||
| matches: |
There was a problem hiding this comment.
I think it fails here, if there is no backendRefs, then "-" is missing before matches.
There was a problem hiding this comment.
going to keep checking. i figured out how to debug this better locally.
larivierec
changed the title
bjw-s
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Fixed
This should fix the rendering of backendRef when we have a RequestRedirect present.
Even the unittests didn't catch it
Possible drawbacks
I'm not sure this is the intended way to implement the requirement but right now, we validate that a user doesn't input a backendRef with a RequestRedirect but when rendering, it renders it.
Applicable issues
Additional information
Checklist
Chart.yamlhas been bumped according to Semantic Versioning.artifacthub.io/changeschangelog annotation has been updated inChart.yaml. See Artifact Hub documentation for more info.