Fixed types for organization client methods, organization type #443
+101
−35
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
The PR corrects the parameter types for the various create and update methods of the organization client (see #437 for a report on some of the issues). This change is not breaking, but merely adjusting the types to match the shape Zendesk's API expects.
The PR also adds an explicit
Organization
type (based on Zendesk's docs), and updates the method signatures to use that type or its derivatives.I also updated the implementation of the
upsert()
method, which is just duplicatingcreateOrUpdate()
, and deprecated the method, since its naming deviates from the API's.Related Issue(s)
Additional Information
Test Cases
Documentation
Checklist