Skip to content

Conversation

@wolf31o2
Copy link
Member

@wolf31o2 wolf31o2 commented Nov 26, 2025

This is enabled on all clusters for some time. It's not necessary to set anymore.


Summary by cubic

Removed EKS encryption_config from the aws_eks module since cluster encryption is already enabled by default. This simplifies the module and removes a no-op setting.

  • Migration
    • Remove encryption_config from any aws_eks module calls.
    • No changes needed on clusters; encryption remains enabled by default.

Written for commit 9db44c9. Summary will update automatically on new commits.

Summary by CodeRabbit

  • Refactor
    • Removed encryption configuration support from the EKS module. The encryption_config parameter is no longer available for use when provisioning EKS infrastructure. Users relying on this functionality will need to manage encryption configuration through alternative methods.

✏️ Tip: You can customize this high-level summary in your review settings.

This is enabled on all clusters for some time. It's not necessary to set
anymore.

Signed-off-by: Chris Gianelloni <[email protected]>
@wolf31o2 wolf31o2 requested review from a team as code owners November 26, 2025 17:50
@coderabbitai
Copy link

coderabbitai bot commented Nov 26, 2025

📝 Walkthrough

Walkthrough

This change removes the encryption_config variable definition from aws_eks/variables.tf and eliminates the corresponding encryption_config input parameter from the eks module invocation in aws_eks/eks.tf. The modification effectively disables encryption configuration capabilities within the EKS module, with no replacement logic introduced.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

  • Verify that no other files or module calls reference the removed encryption_config variable
  • Confirm that removing encryption_config from the module invocation does not break any dependent infrastructure or introduce unintended behavioral changes
  • Check if any documentation or examples reference the removed encryption configuration

Possibly related PRs

Pre-merge checks and finishing touches

✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix: remove eks encryption config' is a concise, specific description that clearly summarizes the main change in the changeset—removing the encryption_config from the EKS module.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/remove-eks-encryption-config

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b769147 and 9db44c9.

📒 Files selected for processing (2)
  • aws_eks/eks.tf (0 hunks)
  • aws_eks/variables.tf (0 hunks)
💤 Files with no reviewable changes (2)
  • aws_eks/variables.tf
  • aws_eks/eks.tf
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: cubic · AI code reviewer

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

@wolf31o2 wolf31o2 merged commit 684bb32 into main Nov 26, 2025
6 checks passed
@wolf31o2 wolf31o2 deleted the fix/remove-eks-encryption-config branch November 26, 2025 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants