Named Sets and toggle for Set exercise visiblity#201
Open
crimsoncor wants to merge 6 commits intoblockbasti:mainfrom
Open
Named Sets and toggle for Set exercise visiblity#201crimsoncor wants to merge 6 commits intoblockbasti:mainfrom
crimsoncor wants to merge 6 commits intoblockbasti:mainfrom
Conversation
Author
added 4 commits
July 12, 2024 11:05
This wasn't noticeable until I added the ability to collapse sets, but once that was added, it mattered where exactly the new set was inserted
To rename a set, you can long-press on the name of the set in the builder. In order to deal with the new variable length set names, I broke the set name and workout duration into two separate lines in the workout runner. I don't love having to eat up more vertical space that way, but don't have another amazing idea for how to deal with it and I didn't want to shrink down the font size
Makes re-organizing sets much easier and lets you focus on just the current set you're making
29f915d to
9660348
Compare
Author
|
@blockbasti would it be possible to get a review/notes/approval on this PR? cheers, jesse |
added 2 commits
October 22, 2025 14:27
Got removed when rebasing
a8c163f to
49f3421
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.





A couple small quality of life changes as I learn dart and flutter.
Set names are saved to json and show up in the workout runner. I limited them to 15 characters, but even at that length, they can push the timer in the workout builder onto a new line, so I just permanent split the set name and the timer onto separate lines. I also dropped the font size slightly on the set name.