Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depend on Textual >= 0.41 #522

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

godlygeek
Copy link
Contributor

memray tree already uses features that require this version (TextArea was introduced in Textual 0.38, and TextArea.text gained a setter in Textual 0.41).

Correct our package metadata to accurately reflect our supported versions of the Textual dependency.

See #518

@codecov-commenter
Copy link

codecov-commenter commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d491065) 92.37% compared to head (1dd0b7a) 92.23%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #522      +/-   ##
==========================================
- Coverage   92.37%   92.23%   -0.15%     
==========================================
  Files          91       91              
  Lines       11270    11270              
  Branches     1571     1571              
==========================================
- Hits        10411    10395      -16     
- Misses        854      870      +16     
  Partials        5        5              
Flag Coverage Δ
cpp 85.39% <ø> (-0.44%) ⬇️
python_and_cython 95.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

`memray tree` already uses features that require this version
(`TextArea` was introduced in Textual 0.38, and `TextArea.text` gained
a setter in Textual 0.41).

Correct our package metadata to accurately reflect our supported
versions of the Textual dependency.

Signed-off-by: Matt Wozniski <[email protected]>
@godlygeek godlygeek force-pushed the update_textual_requirement branch from 7781a75 to 1dd0b7a Compare January 12, 2024 22:08
@godlygeek godlygeek merged commit e6f9e0a into bloomberg:main Jan 16, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants