Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for 1.12.0 release #563

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Prepare for 1.12.0 release #563

merged 1 commit into from
Apr 10, 2024

Conversation

pablogsal
Copy link
Member

See changelog for more details.

Issue number of the reported bug or feature request: #

Describe your changes
A clear and concise description of the changes you have made.

Testing performed
Describe the testing you have performed to ensure that the bug has been addressed, or that the new feature works as planned.

Additional context
Add any other context about your contribution here.

@codecov-commenter
Copy link

codecov-commenter commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.93%. Comparing base (41248ed) to head (9b979b4).
Report is 26 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #563      +/-   ##
==========================================
+ Coverage   92.55%   92.93%   +0.38%     
==========================================
  Files          91       91              
  Lines       11304    11195     -109     
  Branches     1581     2047     +466     
==========================================
- Hits        10462    10404      -58     
+ Misses        837      791      -46     
+ Partials        5        0       -5     
Flag Coverage Δ
cpp 92.93% <100.00%> (+6.99%) ⬆️
python_and_cython 92.93% <100.00%> (-2.79%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pablogsal pablogsal enabled auto-merge (rebase) March 7, 2024 18:06
See changelog for more details.

Signed-off-by: Pablo Galindo <[email protected]>
@inglor
Copy link

inglor commented Apr 8, 2024

What's blocking this ?

@pablogsal
Copy link
Member Author

What's blocking this ?

We just need some time to go through it. It should be done by this week

CC: @godlygeek

Copy link
Contributor

@godlygeek godlygeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pablogsal pablogsal merged commit e75462b into bloomberg:main Apr 10, 2024
18 checks passed
@pablogsal pablogsal deleted the release branch April 10, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants