Completed project - Cora Jacobson #65
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swift-student
left a comment
swift-student
left a comment
There was a problem hiding this comment.
Nice job on this one, Cora! You did great on all the assignments from the first sprint. Keep it up :)
Comment on lines
+34
to
+35
| let formatter = NumberFormatter() | ||
| formatter.numberStyle = .currency |
There was a problem hiding this comment.
Nice job getting the currency formatter working.
Comment on lines
+44
to
+50
| convert(amountString: "15.00") | ||
| convert(amountString: "25.00") | ||
|
|
||
| currency = Currency.mxn | ||
|
|
||
| convert(amountString: "15.00") | ||
| convert(amountString: "25.00") |
There was a problem hiding this comment.
I appreciate the test cases here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@swift-student