Completed the project #67
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swift-student
left a comment
swift-student
left a comment
There was a problem hiding this comment.
Great work again, James! You are showing solid understanding of all the concepts in this first sprint. Keep it up.
Comment on lines
+54
to
+58
| var currencyFormatter: NumberFormatter = { | ||
| let formatter = NumberFormatter() | ||
| formatter.numberStyle = .currency | ||
| return formatter | ||
| }() |
There was a problem hiding this comment.
Great job using the number formatter to get the currency, and initializing it with a closure (that's what we it call when you do = { ... }()
Comment on lines
+62
to
+66
| let USD_String = currencyFormatter.string(from: 1.00) | ||
| currency = .CAD | ||
| let CAD_String = currencyFormatter.string(from: NSNumber(value: convert(USD))) | ||
| currency = .MXN | ||
| let MXN_String = currencyFormatter.string(from: NSNumber(value: convert(USD))) |
There was a problem hiding this comment.
Remember that by convention in Swift, variables should be lowercased, and not use underscores. I would suggest usdString cadString mxnString.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@swift-student