Donna Mayfield Swift Fund III Currency #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swift-student
left a comment
swift-student
left a comment
There was a problem hiding this comment.
Not much to suggest on this one, as it is a small project. You did great, finished all required tasks as well as the stretch goal. Very good job on all of the assignments from the first sprint, Donna!
Comment on lines
+41
to
+42
| let cad = convert(amount) | ||
| return String(cad) |
There was a problem hiding this comment.
Maybe name this variable something that is agnostic to the currency being converted to, such as convertedAmount. This way you can switch the currency between mxn and cad or any other currency that you would add in the future.
Comment on lines
+3
to
+7
| var currencyFormatter: NumberFormatter = { | ||
| let formatter = NumberFormatter() | ||
| formatter.numberStyle = .currency | ||
| return formatter | ||
| }() |
There was a problem hiding this comment.
Great job figuring out the currency formatting!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@swift-student