Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: apply latest EIP-7702 changes #1850

Open
wants to merge 2 commits into
base: release/v50
Choose a base branch
from

Conversation

klkvr
Copy link
Contributor

@klkvr klkvr commented Nov 7, 2024

Applies changes from ethereum/EIPs#8969

Instead of Eip7702CodeLoad code reading methods now return StateLoad and only account for cost of loading the target account

@klkvr
Copy link
Contributor Author

klkvr commented Nov 8, 2024

@rakita how should we deal with failing state tests?

@rakita
Copy link
Member

rakita commented Nov 8, 2024

@rakita how should we deal with failing state tests?

We should wait for tests to be released before merging it.

In general, changes look good, but there are two things here:

  1. When is this going to be included (devnet-n)
  2. Should Revm devnet changes be in the branch as there is a devnet branch in reth. This would mean patches/gitpath in revm-inspector and reth

@klkvr
Copy link
Contributor Author

klkvr commented Nov 9, 2024

  1. When is this going to be included (devnet-n)

Seems that in devnet-5 https://notes.ethereum.org/@ethpandaops/pectra-devnet-5

  1. Should Revm devnet changes be in the branch as there is a devnet branch in reth. This would mean patches/gitpath in revm-inspector and reth

For devnet-4 changes we were pretty much always just pushing them to main in both alloy and reth. Separate branch was just for convenience when providing devops team with the latest version

@rakita
Copy link
Member

rakita commented Nov 9, 2024

  1. When is this going to be included (devnet-n)

Seems that in devnet-5 https://notes.ethereum.org/@ethpandaops/pectra-devnet-5

Cool, good link, it is in next releas,more on changes here: https://discord.com/channels/595666850260713488/745077610685661265/1302999973167759416

Let's delay it until Mekong is near it's end.

  1. Should Revm devnet changes be in the branch as there is a devnet branch in reth. This would mean patches/gitpath in revm-inspector and reth

For devnet-4 changes we were pretty much always just pushing them to main in both alloy and reth. Separate branch was just for convenience when providing devops team with the latest version

I want to break the notion that this was good behavior, as it pulls the narative that participating in devnet would require publishing crates. Having this charges in a branch is more on the lime of concept of dev chain

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants