Make lex-gen type more precise #2956
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthieusieben
force-pushed
the
msi/lex-gen-typefixes
branch
4 times, most recently
from
f22ff9f
to
005584a
Compare
matthieusieben
force-pushed
the
msi/lex-gen-typefixes
branch
4 times, most recently
from
71b5042
to
8b364ce
Compare
matthieusieben
force-pushed
the
msi/lex-gen-typefixes
branch
2 times, most recently
from
f5707e0
to
3e52922
Compare
matthieusieben
commented
Nov 12, 2024
Comment on lines
-64
to
-72
| declare global { | ||
| interface Array<T> { | ||
| findLast( | ||
| predicate: (value: T, index: number, obj: T[]) => unknown, | ||
| thisArg?: any, | ||
| ): T | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
This is not the proper type def for this method. The correct signature is provided by ts's 2023 lib. We need the correct def for the updatePreferences methods to work.
Since we are relying on this method, I updated the tsconfig to use 2023 lib instead of 2022.
matthieusieben
force-pushed
the
msi/lex-gen-typefixes
branch
from
8609d87
to
a94fa12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2952
While reviewing, "codegen" commits can be ignored ;-)