Skip to content

Keep the Following pill up until the reader reaches the top - #11942

Draft
mozzius wants to merge 7 commits into
samuel/app-3351-following-every-return-checkfrom
samuel/app-3352-following-pill-until-top
Draft

mozzius wants to merge 7 commits into
samuel/app-3351-following-every-return-checkfrom
samuel/app-3352-following-pill-until-top

Conversation

@mozzius

@mozzius mozzius commented Oct 11, 2026 •

Copy link
Copy Markdown
Member

Fixes APP-3352. Stacked on #11941.

What it does

  • The pill stays until the top. Scrolling into the new posts no longer hides it. It hides when you:
    • reach or come to rest at the very top;
    • press it;
    • pull to refresh;
    • or once none of its posts are showing any more.
  • Marking posts as read hasn't changed. Scrolling into the new posts still marks them read, so the next check adds newer posts above them rather than swapping them out from under you.
  • It grows. While the pill is up, posts that later checks add above it join it, whether the check was timed, on focus or from a quick return. The count is the posts it covers that are still showing, one per post. The faces work as before.
  • How it tracks posts. It knows each batch by the point it was fetched from, so a batch that's refetched and replaced isn't counted twice.
  • Pressing it hides it straight away and scrolls to the top.
  • Cheap when idle. With no offer up and nothing to take in, the pill doesn't scan the feed's rows, so other feeds don't pay for it on every render.

Known issues

  • Posts loaded with "Show more posts" below the new posts aren't counted in the pill.
  • After the pill has been hidden, it only comes back on a new restore or a significant return, never from a timed check. It goes up at most once for each staged page.

Test plan

  • pnpm test src/features/followingV2 src/lib/appState (266 tests), pnpm typecheck, pnpm lint. New tests cover:
    • the pill staying up after the reader sees a new post;
    • growth from timed checks and quick returns;
    • hiding at the top and at rest at the top (through PostFeed's real wiring), and on a press, on a refresh and when nothing it offers is showing (unit tests);
    • a dismissed pill not coming back without a new offer.
  • Device: with the pill up after a warm open, scroll into the new posts. The pill should stay. Wait for a timed check: the count should grow. Scroll to the top: the pill should hide.

🤖 Generated with Claude Code

@mozzius
mozzius added this pull request to stack #11943 October 11, 2026 12:43
@linear-code

linear-code Bot commented Oct 11, 2026

Copy link
Copy Markdown

APP-3352

@mozzius mozzius changed the title samuel/app 3352 following pill until top Keep the Following pill up until the reader reaches the top Oct 11, 2026
@github-actions

github-actions Bot commented Oct 11, 2026 •

Copy link
Copy Markdown
Contributor
Size Old size New size Diff
Uncompressed 9.76 MB 9.76 MB +1.09 KB (0.01%)
Gzip 2.86 MB 2.86 MB +455 B (0.02%)

@github-actions

github-actions Bot commented Oct 11, 2026 •

Copy link
Copy Markdown
Contributor

The OTA deployment for this PR was successful! You may now apply it by either scanning the QR code or opening the deep link below in your browser:

QR code for the PR OTA deployment

bluesky://intent/apply-ota?channel=pull-request-11942&releaseVersion=1.138.0&iosBuildNumber=2263&androidBuildNumber=1704

@mozzius
mozzius force-pushed the samuel/app-3352-following-pill-until-top branch from 1c8c0b5 to 6908fce Compare October 12, 2026 12:04
@mozzius
mozzius force-pushed the samuel/app-3352-following-pill-until-top branch from 6908fce to 1c8c0b5 Compare October 12, 2026 18:09
@mozzius
mozzius force-pushed the samuel/app-3352-following-pill-until-top branch from 1c8c0b5 to 9f941f1 Compare October 13, 2026 11:55
@mozzius
mozzius force-pushed the samuel/app-3352-following-pill-until-top branch from 9f941f1 to d696db9 Compare October 14, 2026 08:04
@mozzius
mozzius force-pushed the samuel/app-3352-following-pill-until-top branch from d696db9 to acbfbb8 Compare November 3, 2026 15:01
@mozzius
mozzius force-pushed the samuel/app-3352-following-pill-until-top branch from acbfbb8 to e288143 Compare November 5, 2026 15:16
mozzius and others added 7 commits November 9, 2026 20:05
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…its docs

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@mozzius
mozzius force-pushed the samuel/app-3352-following-pill-until-top branch from e288143 to ec726f4 Compare November 9, 2026 18:11

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant