Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
The Pull Request introduced native fingerprint changes against the base commit. Generated by PR labeler 🤖 |
Contributor
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes APP-3850. Notifications v2 is now the only Notifications screen. This removes the
notifications_v2:enablegate and deletes the original (v1) screen. Stacked on #12278 (compact quotes in Notifications v2).The gate
NotificationsScreenrenders the v2 screen directly.NewNotificationsScreenis gone, and the screen'stestIDis nownotificationsScreen. The e2e flows already used v2's IDs.isOnForBetaUserstays. Its test now runs againstmoderation_inbox:enable.v1 code removed
view/screens/Notifications.tsx),NotificationFeedandNotificationFeedItem.state/queries/notifications/feed.ts. Post and profile shadows and the post thread placeholder now read only the grouped notifications cache.useAnimatedValue,StarterPackCard.Notification(plusCard'snoIcon/noDescription), and the v1 rows in the moderation playground. The playground keeps its v2 "every kind" section.Unread badge
The unread poller still uses
listNotificationsfor the badges and the Refresh pill. It used to build v1's grouped feed page so the v1 feed could reuse it as its first page. Now:getCachedUnreadPage,invalidateCachedUnreadPageandcheckUnread({invalidate})are gone.checkUnreadis internal to the provider now, since nothing outside it called it.markAllReadnow requiresseenAt. Its fallback was the last check's sync time, and the v2 screen always passesseenAt.pushNotificationOpened, which v2 listens for.notifications:bundleExpandkeeps v1's kind names (post-like, …) so the metric stays comparable.After merge
The
notifications_v2:enableflag can be archived in GrowthBook.Testing
pnpm typecheck,pnpm lintand the notifications, post thread and feature tests pass.🤖 Generated with Claude Code