-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DMs inbox #7778
Open
mozzius
wants to merge
20
commits into
main
Choose a base branch
from
samuel/dms-inbox
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
DMs inbox #7778
+1,372
−213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3732ec8
to
ccc0ce7
Compare
|
08016f1
to
6fd7d97
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incoming messages go into a "chat request" screen, and must be accepted before they go into the primary chat list.
Lot of stuff going on here so I'll just note some details that aren't obvious from just the screenshots:
accepted
andrequest
) andadding both unread counts togethershowing a dot if there's requests but no accepted, otherwise adding accepted +Math.min(request, 1)
. There is no "seen" badge behaviour in this PR. Both pages need to be fetched so that we can still do the log tailing behaviour for all chats.request
stateInbox preview
Chat request screen
Reject menu
Not-accepted chat screen
Also contains a mockup for a mark all as read button, but has not been implemented
mark.all.as.read.mp4
Test plan
Send a DM to yourself from a new account