Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DMs inbox #7778

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

DMs inbox #7778

wants to merge 20 commits into from

Conversation

mozzius
Copy link
Member

@mozzius mozzius commented Feb 18, 2025

Incoming messages go into a "chat request" screen, and must be accepted before they go into the primary chat list.

Lot of stuff going on here so I'll just note some details that aren't obvious from just the screenshots:

  • The badge is now calculated by fetching both pages (accepted and request) and adding both unread counts together showing a dot if there's requests but no accepted, otherwise adding accepted + Math.min(request, 1). There is no "seen" badge behaviour in this PR. Both pages need to be fetched so that we can still do the log tailing behaviour for all chats.
  • Chats are automatically accepted when replying, which is why we just keep the text input on the "not-accepted" convo screen. we could replace it with a button if preferred - PR here (optional, depends what design we think is best)
  • Leaving a chat moves it back to the request state

Inbox preview

iOS web

Chat request screen

iOS web

Reject menu

iOS web

Not-accepted chat screen

iOS web

Also contains a mockup for a mark all as read button, but has not been implemented

mark.all.as.read.mp4

Test plan

Send a DM to yourself from a new account

  • Confirm the badge count is as expected
  • Confirm that when you send a second message, the log system still works and the convo is updated
  • Confirm leaving/blocking/reporting from the inbox works
  • Confirm the not-accepted UI shows and works
  • Confirm the not-accepted UI hides as soon as you send a message
  • Confirm pressing the accept button from the inbox goes to the chat and the not-accepted UI is never visible (even for a flash, it should be updated optimistically)

@arcalinea arcalinea temporarily deployed to samuel/dms-inbox - social-app PR #7778 February 18, 2025 22:40 — with Render Destroyed
@arcalinea arcalinea temporarily deployed to samuel/dms-inbox - social-app PR #7778 February 18, 2025 22:44 — with Render Destroyed
Copy link

github-actions bot commented Feb 18, 2025

Old size New size Diff
6.96 MB 6.96 MB 43 B (0.00%)

@arcalinea arcalinea temporarily deployed to samuel/dms-inbox - social-app PR #7778 February 21, 2025 20:19 — with Render Destroyed
@arcalinea arcalinea temporarily deployed to samuel/dms-inbox - social-app PR #7778 February 21, 2025 20:23 — with Render Destroyed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants