Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed flexibility of feed search #7779

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

MichaScant
Copy link

Relates to issue #7700,

Searching through feeds no longer requires exact wording, even if your search skipped the middle word or punctuation, the result should still appear

@MichaScant MichaScant marked this pull request as draft February 18, 2025 23:52
@MichaScant MichaScant marked this pull request as ready for review February 21, 2025 21:05
@MichaScant
Copy link
Author

Hello, as an update, even though the change I made to the front end works, I believe a better solution would be to modify the backend in atproto, specifically reformating the query to replace all spaces with '%' such that it doesn't perform strict matching. Below is a screenshot of a change I would make in the 'feed-gens.ts' file in atproto to achieve the solution.

Please let me know if this is preferable, and I will open a pr in that repository.

Screenshot 2025-02-21 at 4 07 50 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant