Skip to content

ENH: handler for hdf5 files that have variable frames per point#11

Open
tacaswell wants to merge 8 commits intobluesky:masterfrom
tacaswell:ad_hdf5v1
Open

ENH: handler for hdf5 files that have variable frames per point#11
tacaswell wants to merge 8 commits intobluesky:masterfrom
tacaswell:ad_hdf5v1

Conversation

@tacaswell
Copy link
Copy Markdown
Contributor

Work with @mrakitin to enable variable size images in streams

@danielballan
Copy link
Copy Markdown
Member

Nice to see! I recall this limitation came up in our recent internal-DAMA ophyd tutorial. Funny that it showed up in the wild so soon after.

Copy link
Copy Markdown
Member

@mrakitin mrakitin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've done the py2->3 conversion.

@mrakitin
Copy link
Copy Markdown
Member

@danielballan
Copy link
Copy Markdown
Member

Can you explain more about the connection to dotted_name?

@mrakitin
Copy link
Copy Markdown
Member

Can you explain more about the connection to dotted_name?

It's used here: https://github.com/NSLS-II-FXI/profile_collection/pull/3/files#diff-87e76dd09be85349d2409d8fdd9695e9R111-R113.

@danielballan
Copy link
Copy Markdown
Member

Sorry, still not up to speed on how that relates to the handler code.

@mrakitin
Copy link
Copy Markdown
Member

My #11 (comment) is not specifically relevant here, but rather is for NSLS2/fxi-profile-collection#3 in terms of the integration testing on the beamline. Sorry about the confusion.

@danielballan
Copy link
Copy Markdown
Member

Ohhh right. No, I’m sorry for being dense. :-)

@danielballan
Copy link
Copy Markdown
Member

Rebased, satisfied flake8, added entrypoints.

@danielballan
Copy link
Copy Markdown
Member

This still needs a unit test, but it's ready for testing in the wild at FXI.

@mrakitin mrakitin marked this pull request as ready for review August 26, 2020 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants