Reconfigurable search spaces#268
Merged
thopkins32 merged 15 commits intomainfrom Mar 27, 2026
Merged
Conversation
thopkins32
reviewed
Mar 13, 2026
Collaborator
thopkins32
left a comment
thopkins32
left a comment
There was a problem hiding this comment.
Discussed offline:
DOFkey handled at agent levelstrkey handled at optimizer levelChoiceDOFsupport
josephhanrahan
force-pushed
the
recon-search-space
branch
from
5b1a1c2 to
02b274d
Compare
thopkins32
reviewed
Mar 25, 2026
Collaborator
thopkins32
left a comment
thopkins32
left a comment
There was a problem hiding this comment.
Looks correct. I wonder if we can reduce the amount of validation we do. I imagine Ax does some internal validation. They have more parameter metadata so they can probably validate much better than we can.
Can you check what happens with your current tests if we remove all validation logic?
Recon search space2
thopkins32
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow updating
RangeDOFbounds mid-experiment withAgent.reconfigure_search_space().Closes #245