Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow non ascii names #1570

Closed
wants to merge 3 commits into from
+10 −5
Closed

Allow non ascii names #1570

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
111a104
Allow non-ASCII letters and spaces in names, truncate long names in u…
yoyounik Jan 15, 2025
c68bb3d
changes made
yoyounik Jan 15, 2025
e551154
only contain letter and spaces
yoyounik Jan 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions Client/src/Components/Sidebar/index.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,12 @@ aside .MuiList-root .MuiListItemText-root + svg {
opacity: 0.9;
}

.user-context-menu .user-name {
white-space: nowrap;
overflow: hidden;
text-overflow: ellipsis;
}

/* TRANSITIONS */
aside {
flex: 1;
Expand Down
2 changes: 1 addition & 1 deletion Client/src/Validation/validation.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ const nameSchema = joi
.string()
.max(50)
.trim()
.pattern(/^[A-Za-z]+$/)
.pattern(/^[\p{L} ]+$/u)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Input is validated on the backend as well so the validation there needs to be updated to match

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes @ajhollid i will update you with the backend code as well in few days, apologies for the wait.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem, my apologies as well for the slow PR review, it's been a busy couple days! Take your time and ping me when you're ready 👍

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hii @ajhollid i have raised a new PR: #1598, for the updated code , the code is working but i am facing little bit problem with running on docker.
Can you please check the updated PR once and let me know if it is good.

.messages({
"string.empty": "Name is required",
"string.max": "Name must be less than 50 characters long",
Expand Down