Feat/status page pagespeed section#3452
Conversation
6427262 to
c7d9331
Compare
ajhollid
left a comment
There was a problem hiding this comment.
It's getting there! Some more mostly maintenance related changes, please have a look at my comments. Thank you!
ajhollid
left a comment
There was a problem hiding this comment.
Looks pretty good, I think just a naming convention issue and we should be good here.
|
Thanks for the suggestions. made changes to reflect naming convention changes. Also,
|
ajhollid
left a comment
There was a problem hiding this comment.
Mostly good, major issue with the TimescaleDB implementation though, please be sure to review and actually test that.
We should avoid the cast to PageSpeedCheck as well since it's type is narrower than Check. Casting to PageSpeedCheck type makes invalid assumptions about what data is present in a Check object.
|
@ajhollid made changes based on comments. Please do let me know if it needs changes |
Adding PageSpeed section to the Status page.
accidently closed before force pushing to fix rebase issue
#3443
All reviewed changes have been made
<div>Add</div>, use):npm run formatin server and client directories, which automatically formats your code.