Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BEP-524: short block interval phase two: 0.75 seconds #524

Merged
merged 6 commits into from
Feb 20, 2025

Conversation

zzzckck
Copy link
Contributor

@zzzckck zzzckck commented Feb 19, 2025

Description

There would be 2 phases to shorten BSC block interval from 3 seconds to 0.75 seconds:

  • Phase 1: 3s -> 1.5s
  • Phase 2: 1.5s -> 0.75s

TwoPhase strategy is to avoid one big step to reduce it to 0.75s directly, which could be too risky, as the overall infrastructure may not be fully ready to this change.
And it also update some parameters of Phase-1:

  • Epoch: 2000 -> 1000, too long epoch would be not good to update the validator set timely
  • GasLimit: simply prefer 60M over 65M
  • Blob Update Fraction: it actually have very limited impact to BSC blob gas price, prefer to remove it for simplicity.
  • TurnLength: some users may be very cautiously toward TX finalization, they would wait for (2/3)Validators before confirm the transaction. It would be (2/3)21321.5s = 672 seconds, which is too long.

@zzzckck zzzckck force-pushed the bep520_short_block_interval branch from 8f7ad6b to 54d24f7 Compare February 19, 2025 06:58
@zzzckck zzzckck marked this pull request as draft February 19, 2025 06:58
in case TurnLength == 32, several validators together can bring down
GasLimit a lot, so reasonable to increase it.
@zzzckck zzzckck changed the title BEP-522: short block interval phase two BEP-524: short block interval phase two Feb 20, 2025
@zzzckck zzzckck force-pushed the bep520_short_block_interval branch from 69a542b to 09fc534 Compare February 20, 2025 07:30
@zzzckck zzzckck force-pushed the bep520_short_block_interval branch from 09fc534 to e1c0cba Compare February 20, 2025 07:32
@zzzckck zzzckck marked this pull request as ready for review February 20, 2025 07:37
buddh0
buddh0 previously approved these changes Feb 20, 2025
@zzzckck zzzckck changed the title BEP-524: short block interval phase two BEP-524: short block interval phase two: 0.75 seconds Feb 20, 2025
@zzzckck zzzckck merged commit c5bdac4 into bnb-chain:master Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants