Skip to content

Conversation

@jedel1043
Copy link
Member

@jedel1043 jedel1043 commented Oct 3, 2023

Should probably be merged after we merge #3348. Not required anymore.

@jedel1043 jedel1043 added dependencies Pull requests that update a dependency file test Issues and PRs related to the tests. labels Oct 3, 2023
@jedel1043 jedel1043 added this to the v0.18.0 milestone Oct 3, 2023
@jedel1043 jedel1043 requested a review from a team October 3, 2023 21:04
@github-actions
Copy link

github-actions bot commented Oct 3, 2023

Test262 conformance changes

Test result main count PR count difference
Total 95,574 95,609 +35
Passed 75,342 75,357 +15
Ignored 19,482 19,490 +8
Failed 750 762 +12
Panics 0 0 0
Conformance 78.83% 78.82% -0.01%
Fixed tests (6):
test/harness/verifyProperty-desc-is-not-object.js [strict mode] (previously Failed)
test/harness/verifyProperty-desc-is-not-object.js (previously Failed)
test/harness/verifyProperty-value-error.js [strict mode] (previously Failed)
test/harness/verifyProperty-value-error.js (previously Failed)
test/built-ins/Object/prototype/toString/symbol-tag-non-str-builtin.js [strict mode] (previously Ignored)
test/built-ins/Object/prototype/toString/symbol-tag-non-str-builtin.js (previously Ignored)

@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (3f80823) 49.55% compared to head (66bd33f) 46.05%.
Report is 30 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3349      +/-   ##
==========================================
- Coverage   49.55%   46.05%   -3.50%     
==========================================
  Files         446      474      +28     
  Lines       43732    48742    +5010     
==========================================
+ Hits        21673    22450     +777     
- Misses      22059    26292    +4233     

see 99 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jedel1043
Copy link
Member Author

Maybe #3348 will take a bit of time until we decide the best result repr, so I think we can merge this. I'll bump it to the latest commit.

@jedel1043 jedel1043 requested a review from a team October 14, 2023 23:01
@raskad raskad added this pull request to the merge queue Oct 15, 2023
Merged via the queue into main with commit c9f5e02 Oct 15, 2023
@HalidOdat HalidOdat deleted the bump-test262 branch October 15, 2023 13:29
sam-finch-tezos pushed a commit to trilitech/boa that referenced this pull request Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants