Skip to content

Add SparseElement variant for simple sparse array storage #4543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add SparseElement variant for simple sparse array storage #4543

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions cli/src/debug/object.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ fn id(_: &JsValue, args: &[JsValue], _: &mut Context) -> JsResult<JsValue> {
}

/// Returns objects pointer in memory.
fn indexed_elements_type(_: &JsValue, args: &[JsValue], _: &mut Context) -> JsResult<JsValue> {
fn indexed_storage_type(_: &JsValue, args: &[JsValue], _: &mut Context) -> JsResult<JsValue> {
let Some(value) = args.first() else {
return Err(JsNativeError::typ()
.with_message("expected object argument")
Expand All @@ -39,7 +39,8 @@ fn indexed_elements_type(_: &JsValue, args: &[JsValue], _: &mut Context) -> JsRe
IndexProperties::DenseI32(_) => "DenseI32",
IndexProperties::DenseF64(_) => "DenseF64",
IndexProperties::DenseElement(_) => "DenseElement",
IndexProperties::Sparse(_) => "SparseElement",
IndexProperties::SparseElement(_) => "SparseElement",
IndexProperties::SparseProperty(_) => "SparseProperty",
};
Ok(js_string!(typ).into())
}
Expand All @@ -48,8 +49,8 @@ pub(super) fn create_object(context: &mut Context) -> JsObject {
ObjectInitializer::new(context)
.function(NativeFunction::from_fn_ptr(id), js_string!("id"), 1)
.function(
NativeFunction::from_fn_ptr(indexed_elements_type),
js_string!("indexedElementsType"),
NativeFunction::from_fn_ptr(indexed_storage_type),
js_string!("indexedStorageType"),
1,
)
.build()
Expand Down
Loading
Loading