Merge v1.11.0 from spdlog #3
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 7e95963.
Reduce warnings with pedantic compiler `-Wuseless-cast`
`std::span` does not have `const_iterator`. this prevents `to_hex` from being used with `std::span<>`. to fix this, we provide an explicit overload. compare: https://cplusplus.github.io/LWG/issue3320
spdlog: fmt - support `std::span` in `to_hex`
Reset current size if rotated files on open
spdlog::level::level_enum cannot be forward-declared at present, as
the definition does not specify an underlying type.
To allow users to make use of <spdlog/fwd.h> to refer to
level::level_enum without pulling in all of <spdlog/common.h> (which
can be quite costly), specify an underlying type (int) for
level::level_enum, then add a forward-declaration for it to
spdlog/fwd.h.
Note this required explicitly casting level_enum to size_t within ansicolor_sink due to sign-conversion errors:
implicit conversion changes signedness: 'const level::level_enum' to 'std::__1::array::size_type' (aka 'unsigned long') [-Wsign-conversion]
It would appear that an enum with an unspecified underlying type is in
some kind of superposition - it can be treated as both signed _and_
unsigned - using an underlying type of 'unsigned int' triggers even
more warnings of this kind...
Allow forward-declaration of level_enum
Now only getting time if pattern_formatter needs it
On Line 83 someone probably misclicked tab just removed that tab
removed unneeded spaces
added a few missing files/directories to the gitignore
…sing source information
Mongo sink improvements
…t 9.1.x (gabime#2517) * Use 'SPDLOG_FMT_RUNTIME' to fix compilation error throwed MSVC and fmt 9.1.x * Fix gabime#2512
Added fatal warnings option to appveyor
Not needed since fmt 9.x
This only fires when compiling spdlog for MSVC with gcc and main-app with clang: spdlog.lib -> export -> ... class spdlog::details::context_data ... target <- import <- ... struct spdlog::details::context_data ... lld-link: error: undefined symbol: class std::shared_ptr<struct spdlog::details::context_data> __cdecl spdlog::snapshot_context_fields(void)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
42 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR simply merges the current spdlog v1.11.0 version into the structured_v0 branch.
There were two small MR conflicts, mainly related to newline/code style.
This also includes #2 to fix the build