Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BSE-4481: Python Polaris tests #231

Open
wants to merge 21 commits into
base: isaac/spark_test_refactor
Choose a base branch
from

Conversation

IsaacWarren
Copy link
Contributor

@IsaacWarren IsaacWarren commented Feb 12, 2025

Changes included in this PR

Convert all python tabular tests to polaris and fixes azure read issues.

Testing strategy

Running locally

User facing changes

NA

Checklist

  • Pipelines passed before requesting review. To run CI you must include [run CI] in your commit message.
  • I am familiar with the Contributing Guide
  • I have installed + ran pre-commit hooks.

@IsaacWarren IsaacWarren changed the base branch from main to isaac/spark_test_refactor February 14, 2025 22:12
@IsaacWarren IsaacWarren marked this pull request as ready for review February 17, 2025 17:28
@IsaacWarren IsaacWarren changed the title Isaac/polaris tests BSE-4481: Python Polaris tests Feb 17, 2025
Copy link
Contributor

@srilman srilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note, I made a couple of changes in the PyIceberg PR that might affect your stuff. Lmk

@IsaacWarren IsaacWarren requested a review from srilman February 18, 2025 21:41
Copy link
Contributor

@scott-routledge2 scott-routledge2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @IsaacWarren

f"AWS_REGION={os.environ.get('AWS_REGION', 'us-east-2')}",
]
# Can't use run_rank0 because containers aren't pickelable
if bodo.get_rank() == 0:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to broadcast exceptions if any in this case?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call, added

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants