-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BSE-4481: Python Polaris tests #231
base: isaac/spark_test_refactor
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note, I made a couple of changes in the PyIceberg PR that might affect your stuff. Lmk
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @IsaacWarren
f"AWS_REGION={os.environ.get('AWS_REGION', 'us-east-2')}", | ||
] | ||
# Can't use run_rank0 because containers aren't pickelable | ||
if bodo.get_rank() == 0: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to broadcast exceptions if any in this case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call, added
Changes included in this PR
Convert all python tabular tests to polaris and fixes azure read issues.
Testing strategy
Running locally
User facing changes
NA
Checklist
[run CI]
in your commit message.