-
Notifications
You must be signed in to change notification settings - Fork 128
feat(core+prompts): Add suggestion + path prompt #314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: f641a8e The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@example/basic • @example/changesets
commit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @MacFJA, this looks pretty cool, but I would like to see some tests for this 😁
Added unit tests for
|
} | ||
if (this.suggestion.length === 0) { | ||
result.push({ | ||
text: color.hidden('_'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't really like this solution, but wrap-ansi
remove trailing spaces, so I need to put a char 😕
Any idea to improve this part?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i have 2 alternatives which are using a non-breaking space with (\u00A0
) or using a zero-width space (u200B
) but they're also hacky and some tools/editors may not handle zero-width spaces and for the case of non-breaking spaces may still be visible in some terminals, and not truly "empty" 😭. so i'd say we stick with this for now, what do you think @43081j 😁?
Add two new prompts:
path
prompt is a specialized version ofsuggestion
prompt (<=> The function that generate the suggestion list is predefined)