Skip to content

fix: improve authentication middleware by handling exempt paths befor… #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
laken11 merged 1 commit into from
Apr 14, 2025
Merged

fix: improve authentication middleware by handling exempt paths befor… #20

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions src/middleware/auth.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,15 @@ export class AuthMiddleware implements ExpressMiddlewareInterface {
) {}

async use(request: Request, response: Response, next: (err?: any) => any): Promise<any> {
const token = request.headers.authorization?.split(' ')[1];
if (!token) {
return response.status(401).json({ message: 'You must be authenticated to call this API' });
// todo : find a better fix for this
const exemptPaths = ['/auth/login', '/auth/register', '/auth/refresh'];
const isExemptPath = exemptPaths.some((path) => request.path.startsWith(path));
if (isExemptPath) {
return next();
}

const token = request.headers.authorization?.split(' ')[1];
try {
const authData = await this.authService.getCurrentUser(token);
const authData = await this.authService.getCurrentUser(token!);
request.auth = authData;
} catch (error) {
this.logger.error(`An error occurred while validating token, ${error}`);
Expand Down
Loading