Added a fix for a bug where fattr was missing#9
Open
jpts wants to merge 1 commit intobonsaiviking:masterfrom
Open
Added a fix for a bug where fattr was missing#9jpts wants to merge 1 commit intobonsaiviking:masterfrom
jpts wants to merge 1 commit intobonsaiviking:masterfrom
Conversation
p-l-
reviewed
Dec 9, 2019
| else: | ||
| fh, fattr, cachetime = self.handles[path] | ||
| # get fattr if it is missing | ||
| if fattr == None: |
There was a problem hiding this comment.
Suggested change
| if fattr == None: | |
| if fattr is None: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed a bug where sometimes
fattrwas missing.It only makes the call if it is missing, and then caches the request for future use.