setup fuzzing #98
Merged
setup fuzzing #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this commit adds basic support for https://github.com/dvyukov/go-fuzz the only package that's currently being fuzzed is ./pkg/rec several things worth mentioning: I added go-fuzz to go.mod because go-fuzz-build puts it there every time it's invoked (i.e. it adds uncommitted changes to go.mod) to add a tool dependency, I followed the technique described in https://github.com/go-modules-by-example/index/blob/master/010_tools/README.md I added a separate make target for fuzzing, but I also made it a part of `make check` with the intention of making it a part of the release process
|
Fixes #24. |
|
Note that go-fuzz is currently broken in some cases with Go 1.15. See dvyukov/go-fuzz#294 and golang/go#40546. This may come up if you're planning to update to 1.15 soon. |
avereha
approved these changes
Oct 2, 2020
Closed
@ksurent Yes, we plan to update around now. Thanks for pointing this out! |
dgryski
reviewed
Oct 2, 2020
| @@ -0,0 +1,20 @@ | |||
| package rec | |||
There was a problem hiding this comment.
// +build gofuzz
Then this function isn't part of the regular public API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this commit adds basic support for https://github.com/dvyukov/go-fuzz
the only package that's currently being fuzzed is ./pkg/rec
several things worth mentioning:
I added go-fuzz to go.mod because go-fuzz-build puts it there every time it's invoked (i.e.
it adds uncommitted changes to go.mod)
to add a tool dependency, I followed the technique described in
https://github.com/go-modules-by-example/index/blob/master/010_tools/README.md
I added a separate make target for fuzzing, but I also made it a part of
make checkwith the intention of making it a part of the release process