refactor: Update shortcutkey logic #47
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implement shorcutManager module to manage keyboard shortcuts - Prevent shortcuts from triggering inside input, textarea, and content-editable elements (except for Enter key) - Provide methods to register shortcuts, handle keydown events, and clear registered shortcuts - Add createShortcutFromEvent function to generate shortcut keys from KeyboardEvent.
- Implement usePageShortcutKeys custom hook to manage keyboard shortcuts at the page level. - Utilize useEffect to register and clean up the keydown event listener when the page is mounted/unmounted. - Call clearShortcuts on unmount to ensure shortcuts are properly removed.
- Update keyboard shortcuts for invite button, start game button, settings dropdowns, and chat activation using the new shortcut system
- Update keyboard shortcuts for redo, undo, color change, tool change, using the new shortcut system
- Each component manages its own shortcuts and cleans them up when unmounted
choiseona
added
π» FE
2 tasks
|
π Storybook preview deployed to: Visit Storybook Preview |
π¦ Lighthouse Audit ResultsMainPageCategory Scores
Core Web Vitals & Metrics
LobbyPageCategory Scores
Core Web Vitals & Metrics
|
|
π Storybook preview deployed to: Visit Storybook Preview |
π¦ Lighthouse Audit ResultsMainPageCategory Scores
Core Web Vitals & Metrics
LobbyPageCategory Scores
Core Web Vitals & Metrics
|
dbjoung
approved these changes
Mar 21, 2025
| e.preventDefault(); | ||
| action(); | ||
| for (const config of configs) { | ||
| if (config.key.toLowerCase() === shortcutKey) { |
There was a problem hiding this comment.
κ³ μνμ
¨μ΅λλ€ μ μλ..! :D
λ€λ¦μ΄μλλΌ configsλ₯Ό λ°°μ΄μ΄ μλλΌ ν€-μ ννμΈ Map λ±μΌλ‘ λ겨λ°μΌλ©΄ ν€λ€μ΄ μ΄λ²€νΈ λ°μν λλ§λ€ 루ν λμ§ μκ³ λ°λ‘ μνλ configμ μ κ·Όν μ μμ§ μλ ν΄μμ. νΉ λ°°μ΄λ‘ νμ λ€λ₯Έ μ΄μ κ° μμκΉμ?
(+) μ΄μλ μλλΌμ μ΄νλ‘λΈ νμ΅λλ€ :)
choiseona
changed the title
rhino-ty
approved these changes
Jul 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π μμ λ΄μ©
closes #46
π‘ μμΈν μ€λͺ
λ¨μΆν€ κΈ°λ₯
LobbyPage
GameRoomPage
Modal ν¬μ»€μ± μ κ±°
π μ°Έκ³ μλ£ & ꡬν κ²°κ³Ό (μ ν)
λ‘λΉνμ΄μ§
κ²μνμ΄μ§
π’ 리뷰 μꡬ μ¬ν (μ ν)
π© νμ μμ (μ ν)
β μ ν 체ν¬λ¦¬μ€νΈ