Workaround clang bug with basic_string_view
#185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flamefire
force-pushed
the
patch-1
branch
2 times, most recently
from
be8a50f to
2f8b7e1
Compare
Clang < 15 has a bug in c++-20 mode where using the `std::basic_string` constructor taking a pointer and size leads to an undefined symbol `M_construct` when used with Unicode char types Avoid this by using the range constructor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clang < 15 has a bug in c++-20 mode where using the
std::basic_stringconstructor taking a pointer and size leads to an undefined symbolM_constructwhen used with Unicode char types.See llvm/llvm-project#55560
Avoid this by using the range constructor.
Note that when converting this string_view to a std string the bug is triggered again because in
libstdc++thebasic_stringctor fromstd::basic_string_viewdelegates to the size-range ctor and is instantiated if the source type is convertible tostd::basic_string_view.This can be verified by commenting out the
std::basic_string_viewconversion operator inboost::core::basic_string_viewUsing libc++ also works.