Use std::data and std::size for boost equivalents, when possible#207
Closed
Use std::data and std::size for boost equivalents, when possible#207
std::data and std::size for boost equivalents, when possible#207Conversation
This avoids the potential ambiguity between boost:: and std:: functions when the user calls data() or size() unqualified and both alternatives are found via ADL. Refs #206.
Member
|
I like having a test that checks exactly what's being reported as a problem; in this case, invoking |
Member
Author
|
The added tests are for the changes in |
Member
Author
Done. |
The test checks that unqualified calls to data()/size() with boost::span as argument don't cause ambiguity between std:: and boost:: implementations. Fixes #206.
Lastique
force-pushed
the
feature/use_std_data_size
branch
from
8f0f48c to
609c742
Compare
Member
Author
|
Any objections to merging this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoids the potential ambiguity between
boost::andstd::functions when the user callsdata()orsize()unqualified and both alternatives are found via ADL.Fixes #206.