test: add integration tests for 'bootc switch --apply'

[p5]

I've not had chance to setup a local environment for tmt, so hoping I'm able to test in this PR.

This uses the existing test-20-local-upgrade.fmf with a lot of the unneeded tests stripped out. Might move this into that test, we'll see.

If all goes well, tests will fail to begin with. Then when I rebase the fixes, they pass.

[gemini-code-assist]

Code Review

This pull request adds a new integration test for bootc switch --apply. The test creates a derived container image, switches to it, and verifies the system reboots into the new image with the correct kernel arguments.

The changes are logical and well-structured. I've found a critical issue with a filename typo in one of the tmf files that would prevent the test from running. I've also pointed out a few minor improvements in the nushell test script, such as removing unused variables and an unnecessary bash -c wrapper to improve code clarity and maintainability.

Once these points are addressed, the new test will be a valuable addition to the test suite.

[p5]

Hmm. Reading the docs, it doesn't seem like tmt supports rebooting using anything other than the tmt-reboot command. Or if it does, it won't increment the TMT_REBOOT_COUNT variable.

Will rebase to the fix, just in case it happens to work as I expect. Though I doubt it.

[cgwalters]

Hmm. Reading the docs, it doesn't seem like tmt supports rebooting using anything other than the tmt-reboot command. Or if it does, it won't increment the TMT_REBOOT_COUNT variable.

Yes see #1419

[henrywang]

Hi @p5,
I reopen this PR to add test for --apply. I added my research in #1419.

I can't push to your rsturla/bootc.git repository due to permission error. Could you please help to update the test-image-upgrade-reboot.nu. This should work. Thanks!

diff --git i/tmt/tests/booted/test-image-upgrade-reboot.nu w/tmt/tests/booted/test-image-upgrade-reboot.nu
index e4e8498..6c5ff5a 100644
--- i/tmt/tests/booted/test-image-upgrade-reboot.nu
+++ w/tmt/tests/booted/test-image-upgrade-reboot.nu
@@ -39,7 +39,7 @@ COPY usr/ /usr/
     podman build -t localhost/bootc-derived .
 
     # Now, switch into the new image
-    bootc switch --apply --transport containers-storage localhost/bootc-derived
+    tmt-reboot -c "bootc switch --apply --transport containers-storage localhost/bootc-derived"
 
     # We cannot perform any other checks here since the system will be automatically rebooted
 }

[p5]

Thanks for the pointer @henrywang !

Your patch has been applied and squashed into the existing commit. The integration tests seemingly are passing, so think this is ready for some reviews!

This test should:

1. boot into a VM
2. create a new image with kargs changes
3. switch into the new image with the --apply flag
4. verify kargs changes persisted

---

Edit: I'm not actually sure that this is working as we intended.
This branch is prior to the fixes in #1417, so I would expect the builds to be failing until we rebased. Looking into it.

[p5]

This doesn't seem to work - perhaps TMT reboots at the end of the command if the command itself doesn't?

Maybe we do something like:

tmt-reboot -c "bootc switch --apply --transport containers-storage localhost/bootc-derived && exit 1"

In theory, if the --apply flag works, the exit 1 should never be reached and the tests continue as expected.
If the exit 1 is hit, it should mean --apply didn't initiate a reboot, and the test will rightfully fail.

Thoughts?

[henrywang]

According to https://tmt.readthedocs.io/en/stable/stories/features.html#reboot-during-test and code https://github.com/teemtee/tmt/blob/main/tmt/steps/scripts/tmt-reboot, the tmt-reboot will not reboot the system if -c used.