-
Notifications
You must be signed in to change notification settings - Fork 129
governance: add community manager role #1538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Feel free to adjust wording as needed, this is just an example. This is a good way to empower PMs other folks to be able to help out with meta things around the project. We explicitly list the the role in governance so that the people listed here end up in the main cncf maintainers.csv. Being in the csv file is important because it is a check the CNCF uses to ensure maintainers are requesting the resources. And for CFP submissions, "did one of the maintainers submit this talk or was it someone else?", etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a new 'Community Manager' role by adding a new section to MAINTAINERS.md
. This is a positive step towards empowering more contributors for administrative duties. My review focuses on ensuring this governance change is fully integrated and documented. I've raised a high-severity comment about the need to update GOVERNANCE.md
to formally define this new role, and a medium-severity comment to address an inconsistency in the MAINTAINERS.md
file for better maintainability.
# Community Managers | ||
|
||
This group can represent the project for administrative and program manager duties. Examples: CNCF Service Desk tickets, coordinating with CNCF Project and Events teams, and LFX Administration. No code or code review rights. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While adding the Community Manager role here is a good first step, a change of this nature should also be reflected in GOVERNANCE.md
. The PR is titled 'governance: add community manager role', which implies a change to the project's governance structure, but the main governance document is not being updated.
To properly formalize this new role, please consider adding a 'Community Managers' section to GOVERNANCE.md
. This section should define the role, its responsibilities, and the process for nomination and removal, similar to how 'Maintainers' are currently defined. This will ensure the project's governance documentation remains the single source of truth and is complete and consistent.
|
||
| Name | GitHub ID | Employer | Responsibilities | | ||
| ---- | ---- | ---- | ---- | | ||
| Laura Santamaria | [nimbinatus](https://github.com/nimbinatus) | Red Hat | Representative | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency with the maintainer entries in this file, please consider using the orgs/bootc-dev/people
URL for the GitHub ID. The current link https://github.com/nimbinatus
is a direct profile link, while other entries use the format https://github.com/orgs/bootc-dev/people/<id>
to officially associate them with the bootc-dev
organization.
Using a consistent format is important for clarity and for any tooling that might parse this file. If you make this change, you may also need to adjust the column widths in the markdown table to accommodate the longer URL.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems reasonable to me. Thanks!
Feel free to adjust wording as needed, this is just an example.
This is a good way to empower PMs other folks to be able to help out with meta things around the project. We explicitly list the the role in governance so that the people listed here end up in the main cncf maintainers.csv.
Being in the csv file is important because it is a check the CNCF uses to ensure maintainers are requesting the resources. And for CFP submissions, "did one of the maintainers submit this talk or was it someone else?", etc.