-
Notifications
You must be signed in to change notification settings - Fork 5
Documentation upgrade for release v0.9.0 #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
partials/header.html
Outdated
| <title>boringproxy.io</title> | ||
| <link rel="stylesheet" type="text/css" href="/styles.css"> | ||
| <link rel="icon" href="/logo.png"> | ||
| <link rel="icon" href="/logo.svg"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would love to switch to using the SVG (especially for the logo baked into the boringproxy executable), but AFAIK safari still doesn't support SVG favicons.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I will download the current PNG from the website and add it to the repository. I was simply falling back to the one file available to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you wouldn't mind using this logo (recently added to boringproxy repo) that would be ideal:
https://github.com/boringproxy/boringproxy/blob/master/default_logo.png
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can rename it to logo.png for boringproxy.io
|
How much do you care about 941cffa? I'm asking, as this introduces some kind of opinionated handling of the |
|
Is there some reason to change the default output directly? |
|
My personal reason is to cleanly distinguish between build source and build target files. That also helped me with decluttering the staging area while developing/writing. Also, some of the created outputs could not be regenerated through this repository, as the screenshot and logo PNGs, or the videos which are added extra, which was easier to discovery with a clean build directory, speaking as an outsider. |
|
I'd prefer to keep it the way it is. The way I'm running it in production is I just run it in place behind a static file server and would prefer not to fiddle with it. |
This merge request updates the website and documentation with neccessary changes for the latest BoringProxy releases.
Closes #13
In this mainenance session, we can also respect some of the other issues here and follow their suggested improvements.