Skip to content

Conversation

@almereyda
Copy link
Contributor

This merge request updates the website and documentation with neccessary changes for the latest BoringProxy releases.

Closes #13

In this mainenance session, we can also respect some of the other issues here and follow their suggested improvements.

@almereyda almereyda marked this pull request as draft February 20, 2022 14:23
<title>boringproxy.io</title>
<link rel="stylesheet" type="text/css" href="/styles.css">
<link rel="icon" href="/logo.png">
<link rel="icon" href="/logo.svg">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would love to switch to using the SVG (especially for the logo baked into the boringproxy executable), but AFAIK safari still doesn't support SVG favicons.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I will download the current PNG from the website and add it to the repository. I was simply falling back to the one file available to me.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you wouldn't mind using this logo (recently added to boringproxy repo) that would be ideal:

https://github.com/boringproxy/boringproxy/blob/master/default_logo.png

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can rename it to logo.png for boringproxy.io

@almereyda
Copy link
Contributor Author

How much do you care about 941cffa? I'm asking, as this introduces some kind of opinionated handling of the ssg.js CLI, which wasn't present before, and was, in fact, reversed.

@anderspitman
Copy link
Member

Is there some reason to change the default output directly?

@almereyda
Copy link
Contributor Author

My personal reason is to cleanly distinguish between build source and build target files. That also helped me with decluttering the staging area while developing/writing.

Also, some of the created outputs could not be regenerated through this repository, as the screenshot and logo PNGs, or the videos which are added extra, which was easier to discovery with a clean build directory, speaking as an outsider.

@anderspitman
Copy link
Member

I'd prefer to keep it the way it is. The way I'm running it in production is I just run it in place behind a static file server and would prefer not to fiddle with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Release 0.9.0 has different usage patterns

2 participants