-
Notifications
You must be signed in to change notification settings - Fork 53
Add patches to docker-engine-29 #730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4792942 to
a1f6bda
Compare
Signed-off-by: Kush Upadhyay <[email protected]>
a1f6bda to
eb2f2bf
Compare
|
Force push adds a link in the |
|
Force push adds additional patch to force use of containerd snapshotter. Description has been updated with details and testing |
packages/docker-engine-29/0004-force-the-containerd-snapshotter-to-be-used.patch
Outdated
Show resolved
Hide resolved
Signed-off-by: Kush Upadhyay <[email protected]>
Signed-off-by: Kush Upadhyay <[email protected]>
b7d1e11 to
5070375
Compare
|
Force push removes the containerd snapshotter patch as we've found we can do this by replacing the |
Issue number:
#712
Description of changes:
docker-enginebased off this commit by @henry118 to always use containerd's transfer servicecontainerd-2.1basic config (used by ECS) to enable use of transfer service + import containerd dropins folder for further modificationdocker-engine-29daemon jsons to useoverlayfsinstead ofoverlay2for storage-driver so the containerd snapshotter is used instead of the legacy graphdriver. Looking at the docker source code, we found that it defaults to graphdriver if the path/var/lib/docker/overlay2/exists, so this change avoids thatNote: Unlike the containerd k8s config file, for the basic config, we cannot set values based on
settings.container-runtimeas that doesn't exist in the ECS plugin, so resorting to hardcodes for nowTesting done:
Booted an
aws-ecs-3x86 ami from this PR with custom core-kit and ran the following tests on it:Booted an
aws-ecs-3aarch64 ami from this PR with custom core-kit and ran the following tests on it:Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.