feat(kubernetes): add image gc age settings for kubelet config #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add image_maximum_gc_age and image_minimum_gc_age fields to KubernetesSettingsV1 struct to allow configuration of garbage collection age thresholds for container images.
|
Thanks for cutting us this PR. To proceed with the change, you would also need to bump the model version in Cargo.toml. You can refer to this PR for the relevant change - https://github.com/bottlerocket-os/bottlerocket-settings-sdk/pull/80/files |
|
Can you fix the lint warning? You would also need to open up a PR in core-kit like this - bottlerocket-os/bottlerocket-core-kit#541 If your time allows, feel free to open one for that. If not we can work on that, but the work would need to be prioritized. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add image_maximum_gc_age and image_minimum_gc_age fields to KubernetesSettingsV1 struct to allow configuration of garbage collection age thresholds for container images.
Issue #, if available:
Depending on this issue bottlerocket-os/bottlerocket#4544
Description of changes:
I want to update kubelet fields of image_maximum_gc_age and image_minimum_gc_age following this docs https://kubernetes.io/docs/reference/config-api/kubelet-config.v1beta1/