Move remaining variants to EROFS #4728
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Nit: It would be nice if these all showed in the same spot in each variant |
rpkelly
reviewed
Jan 6, 2026
Signed-off-by: Matthew Yeazel <[email protected]>
Signed-off-by: Matthew Yeazel <[email protected]>
Signed-off-by: Matthew Yeazel <[email protected]>
Signed-off-by: Matthew Yeazel <[email protected]>
Signed-off-by: Matthew Yeazel <[email protected]>
Signed-off-by: Matthew Yeazel <[email protected]>
Signed-off-by: Matthew Yeazel <[email protected]>
Signed-off-by: Matthew Yeazel <[email protected]>
Signed-off-by: Matthew Yeazel <[email protected]>
Signed-off-by: Matthew Yeazel <[email protected]>
Signed-off-by: Matthew Yeazel <[email protected]>
Signed-off-by: Matthew Yeazel <[email protected]>
Signed-off-by: Matthew Yeazel <[email protected]>
Signed-off-by: Matthew Yeazel <[email protected]>
Signed-off-by: Matthew Yeazel <[email protected]>
Signed-off-by: Matthew Yeazel <[email protected]>
Signed-off-by: Matthew Yeazel <[email protected]>
Signed-off-by: Matthew Yeazel <[email protected]>
Signed-off-by: Matthew Yeazel <[email protected]>
Signed-off-by: Matthew Yeazel <[email protected]>
Signed-off-by: Matthew Yeazel <[email protected]>
Signed-off-by: Matthew Yeazel <[email protected]>
Signed-off-by: Matthew Yeazel <[email protected]>
Signed-off-by: Matthew Yeazel <[email protected]>
Signed-off-by: Matthew Yeazel <[email protected]>
Signed-off-by: Matthew Yeazel <[email protected]>
Signed-off-by: Matthew Yeazel <[email protected]>
Signed-off-by: Matthew Yeazel <[email protected]>
Signed-off-by: Matthew Yeazel <[email protected]>
Signed-off-by: Matthew Yeazel <[email protected]>
Contributor
Author
|
^ Fixed ordering of where erofs setting is in all Cargo.toml files to be consistent. |
vigh-m
approved these changes
Jan 6, 2026
KCSesh
reviewed
Jan 6, 2026
| grub-set-private-var = true | ||
| uefi-secure-boot = true | ||
| xfs-data-partition = true | ||
| erofs-root-partition = true |
Contributor
There was a problem hiding this comment.
Commit for this file, says vmware-k8s-1.29-fips should be vmware-k8s-1.33-fips
Signed-off-by: Matthew Yeazel <[email protected]>
KCSesh
approved these changes
Jan 6, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Closes # #4727
Description of changes:
Moves the remaining variants to EROFS.
Testing done:
Built and launched samples of the variants to confirm they boot. See #4727 for the boot time analysis.
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.