migration: add ntp refclock and chrony access settings - #4894
Draft
nwjsmith wants to merge 1 commit into
Draft
Conversation
Add the v1.64.0 settings migration for the new settings.ntp keys (refclocks, allow, cmdallow, bindcmdaddress) so they are removed from the datastore on downgrade to versions that don't understand them, and register it in Release.toml. Also document the Amazon Time Sync Service PTP hardware clock setup in the EKS quickstart and the settings reference in the README. Addresses bottlerocket-os#4407 and bottlerocket-os#4473. Signed-off-by: Nate Smith <nate@theinternate.com>
nwjsmith
force-pushed
the
ntp-refclock-and-access-settings
branch
from
July 22, 2026 19:10
f12ebe7 to
d62d22a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number:
Addresses #4407 and #4473
Description of changes:
Adds the settings migration for the new
settings.ntpkeys (refclocks,allow,cmdallow,bindcmdaddress) so they are cleanly removed from the datastore on downgrade to versions that don't understand them, and registers it in the in-development1.64.0migration edge inRelease.toml(alongside the other 1.64.0 migrations, e.g. hugepages and container-runtime-endpoint).Also documents the Amazon Time Sync Service PTP hardware clock setup in the EKS quickstart (
QUICKSTART-EKS.md) and the settings reference inREADME.md.Depends on the
bottlerocket-settings-modelsbump that introduces these fields (separate chore PR, as in #4887) and the core-kit chrony template/udev change.Testing done:
cargo check,cargo clippy, andcargo fmt -- --checkon the new migration crate — clean.(1.63.0, 1.64.0)edge inRelease.toml.Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.
Blocked by bottlerocket-os/bottlerocket-settings-sdk#143