BM-1627: Add RPS limit to powv cli #1156
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wollac
requested review from
a team,
austinabell,
capossele,
willemolding and
zeroecco
as code owners
github-actions
bot
changed the title
willpote
approved these changes
Sep 23, 2025
derrix060
reviewed
Sep 29, 2025
| pub rpc_url: Option<Url>, | ||
|
|
||
| /// Limit the requests per second to the RPC endpoint | ||
| #[clap(long, env = "RPS", global = true, default_value_t = 25)] |
There was a problem hiding this comment.
Not sure defaulting the value to 25 is a good idea. I'd say that the majority of provers are not using a free RPC endpoint, so they would be affected.
Also for backwards compatibility, set the default to unlimited (current behaviour), but allow one configure to a different value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the 'rps' argument to the CLI, limiting the number of requests sent to RPC providers per second. The default is 25, which matches the Alchemy free tier.