BM-1714: add override IPFS gateway #1239
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
capossele
requested review from
a team,
Wollac,
austinabell,
ec2,
willemolding and
zeroecco
as code owners
github-actions
bot
changed the title
willpote
approved these changes
Oct 15, 2025
crates/broker/src/lib.rs
Outdated
Comment on lines
616
to
626
| self.fetch_and_upload_image( | ||
| "assessor", | ||
| prover, | ||
| image_id, | ||
| override_gateway(&image_url_str), | ||
| path, | ||
| default_url, | ||
| ) | ||
| .await | ||
| .context("uploading assessor image")?; | ||
| Ok(image_id) |
There was a problem hiding this comment.
Ideally we try URL, if fail try custom gateway, if fail try contract specified gateway. Since our custom gateway that we pay for is now a point of failure
There was a problem hiding this comment.
Good catch, addressed with d95ad89
austinabell
reviewed
Oct 16, 2025
Comment on lines
+68
to
+75
| let parts: Vec<&str> = url.splitn(2, "/ipfs/").collect(); | ||
| if parts.len() != 2 { | ||
| return url.to_string(); | ||
| } | ||
|
|
||
| let gateway_url = | ||
| std::env::var("IPFS_GATEWAY_URL").unwrap_or(BOUNDLESS_IPFS_GATEWAY_URL.to_string()); | ||
| let new_url = format!("{gateway_url}/ipfs/{}", parts[1]); |
There was a problem hiding this comment.
Suggested change
| let parts: Vec<&str> = url.splitn(2, "/ipfs/").collect(); | |
| if parts.len() != 2 { | |
| return url.to_string(); | |
| } | |
| let gateway_url = | |
| std::env::var("IPFS_GATEWAY_URL").unwrap_or(BOUNDLESS_IPFS_GATEWAY_URL.to_string()); | |
| let new_url = format!("{gateway_url}/ipfs/{}", parts[1]); | |
| let Some((_, cid)) = url.split_once("/ipfs/") else { | |
| return url.to_string(); | |
| }; | |
| let gateway_url = | |
| std::env::var("IPFS_GATEWAY_URL").unwrap_or(BOUNDLESS_IPFS_GATEWAY_URL.to_string()); | |
| let new_url = format!("{gateway_url}/ipfs/{cid}"); |
Completely optional pass-by suggestion to make this a bit cleaner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overrides the IPFS gateway in a given URL. The new gateway URL is taken from the
IPFS_GATEWAY_URLenvironment variable, or defaults toBOUNDLESS_IPFS_GATEWAY_URLif the variable is not set