BM-1908: Add support for FallbackLayer to boundless sdk #1324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
changed the title
willpote
requested review from
a team,
Wollac,
austinabell,
capossele,
ec2,
willemolding and
zeroecco
as code owners
austinabell
reviewed
Nov 18, 2025
Comment on lines
+141
to
+142
| let active_count = | ||
| std::num::NonZeroUsize::new(transports.len()).unwrap_or(std::num::NonZeroUsize::MIN); |
Contributor
There was a problem hiding this comment.
I don't think we should just ignore the case of no transports being selected? This feels like we would be opening up to issues where there are 0 transports, but the fallback layer assumes there is one? Given that we are only calling this if there are values, should this not just pass back an error in this case?
Comment on lines
+124
to
+132
| // Add the primary RPC URL if set | ||
| if let Some(ref rpc_url) = self.rpc_url { | ||
| all_urls.push(rpc_url.clone()); | ||
| } | ||
|
|
||
| // Add any additional URLs from rpc_urls | ||
| all_urls.extend(self.rpc_urls.clone()); | ||
|
|
||
| Ok(all_urls) |
Contributor
There was a problem hiding this comment.
Seems like erroring if all_urls is empty here might be helpful with a message that indicates you need to set either or both variables?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support FallbackLayer in boundless SDK and in broker. This allows configuring multiple RPCs and trying all of them.
Enables it for one of the two single instance provers we operate, so we can monitor and compare perf to the other one