Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vm): handle more than 4 hostpci devices #1543

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

bpg
Copy link
Owner

@bpg bpg commented Sep 20, 2024

Contributor's Note

  • I have added / updated documentation in /docs for any user-facing features or additions.
  • I have added / updated acceptance tests in /fwprovider/tests for any new or updated resources / data sources.
  • I have ran make example to verify that the change works as expected.

Proof of Work

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #1541

@bpg bpg force-pushed the fix-vm-parsing-device-lists branch 2 times, most recently from 3022201 to 6c749f3 Compare September 20, 2024 02:16
@bpg bpg changed the title fix: handle hostpci devices fix(vm): handle hostpci devices Sep 20, 2024
@bpg bpg changed the title fix(vm): handle hostpci devices fix(vm): handle more than 4 hostpci devices Sep 20, 2024
@bpg bpg force-pushed the fix-vm-parsing-device-lists branch from 6c749f3 to 5c55951 Compare September 20, 2024 02:17
@bpg bpg force-pushed the fix-vm-parsing-device-lists branch from 5c55951 to e97048d Compare September 20, 2024 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hostpci always gets updated to same value if set (if more than 4)
1 participant