refactor: use CommonRestrictions.WORKER_LOCK_DURATION_IN_MILLISECONDS constant#198
Merged
Merged
Conversation
… constant Replace the hardcoded "workerLockDurationInMilliseconds" restriction key with the CommonRestrictions.WORKER_LOCK_DURATION_IN_MILLISECONDS constant introduced in process-engine-api 1.6, matching how the other restriction keys are already referenced in the C7 adapters.
emaarco
requested review from
i-am-not-giving-my-name-to-a-machine and
zambrovski
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Replaces the hardcoded
"workerLockDurationInMilliseconds"restriction-key string with theCommonRestrictions.WORKER_LOCK_DURATION_IN_MILLISECONDSconstant, which was introduced inprocess-engine-api1.6 (commitbb1a250).This aligns the lock-duration key with how every other restriction key (
EXECUTION_ID,ACTIVITY_ID,BUSINESS_KEY,TENANT_ID, …) is already referenced in the C7 adapters, removing the last raw restriction-key literal in the codebase.Why
Using the constant avoids silent breakage if the key is ever renamed in
process-engine-api, and keeps the adapters consistent. The constant resolves to the exact same value ("workerLockDurationInMilliseconds"), so there is no behavior change.Changes
Main sources (already imported
CommonRestrictions):c7-remote-corePullServiceTaskDelivery— lock-duration lookup +minus(...)filterc7-embedded-coreEmbeddedPullServiceTaskDelivery— lock-duration lookup +minus(...)filterc7-remote-coreSubscribingServiceTaskDelivery—minus(...)filterTest sources (added the
CommonRestrictionsimport):PullServiceTaskDeliveryTest,SubscribingServiceTaskDeliveryTest,EmbeddedPullServiceTaskDeliveryTestThe backtick test-method names that mention the key were intentionally left unchanged (display names, not keys).
Notes
process-engine-api≥ 1.6 — already satisfied (process-engine-api.versionis1.6in the rootpom.xml).test-compilepasses for both core modules.