refactor: use CommonRestrictions constants instead of raw restriction-key strings#230
Merged
Merged
Conversation
…-key strings Replace hardcoded restriction-key literals with the constants from dev.bpmcrafters.processengineapi.CommonRestrictions (available since process-engine-api 1.6): - workerLockDurationInMilliseconds -> WORKER_LOCK_DURATION_IN_MILLISECONDS (PullUserTaskDelivery, SubscribingRefreshingUserTaskDelivery, SubscribingServiceTaskDelivery + tests) - processDefinitionId -> PROCESS_DEFINITION_ID (StartProcessApiImpl) - tenantId -> TENANT_ID (EvaluateDecisionApiImplTest)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces hardcoded restriction-key string literals with the constants from
dev.bpmcrafters.processengineapi.CommonRestrictions, introduced in process-engine-api 1.6 (commit bb1a250). The repo already depends on 1.6 (pom.xml), and the constantWORKER_LOCK_DURATION_IN_MILLISECONDS = "workerLockDurationInMilliseconds"was verified to exist in the resolved artifact.Changes (8 sites, 6 files)
workerLockDurationInMilliseconds→CommonRestrictions.WORKER_LOCK_DURATION_IN_MILLISECONDS:PullUserTaskDelivery.ktSubscribingRefreshingUserTaskDelivery.ktSubscribingServiceTaskDelivery.kt(2 occurrences)SubscribingServiceTaskDeliveryTest.ktSubscribingRefreshingUserTaskDeliveryTest.ktSame class of issue — other raw restriction keys that already have a constant:
StartProcessApiImpl.kt:"processDefinitionId"→CommonRestrictions.PROCESS_DEFINITION_ID(sat right next to existingCommonRestrictions.*entries)EvaluateDecisionApiImplTest.kt:meta["tenantId"]→meta[CommonRestrictions.TENANT_ID](added the import; removed the now-redundant// CommonRestrictions.TENANT_IDcomment)Verification
./mvnw -pl engine-adapter/c8-core -am test-compile→ BUILD SUCCESS