fix: live preview not working on chrome v111 #263
Merged
+166
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank You for making this pull request. |
abose
commented
Mar 10, 2023
| @@ -43,6 +43,18 @@ function _cmdLaunch(url) { | |||
| open(url); | |||
| } | |||
|
|
|||
| function _launchChromeWithRDP(url, enableRemoteDebugging) { | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
Thank You for making this pull request. |
charlypa
approved these changes
Mar 10, 2023
|
Testing. in progress. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #262
Reason: Chrome added CORS header for the remote debug port used by live preview. We added the appropriate CORS header for the
file:///URLs used by brackets which is*. This is a less secure implementation than the one phcode.dev uses, but as we will be moving to phcode.dev arch, this is a temporary fix.