Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User-installed commands #1223

Merged
merged 6 commits into from
Oct 21, 2024
Merged

User-installed commands #1223

merged 6 commits into from
Oct 21, 2024

Conversation

raxyte
Copy link
Contributor

@raxyte raxyte commented Aug 12, 2024

Adds required support for user-installed commands.

Code change checklist

  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • My code follows the coding style guide.
  • I tested that my change works before raising the PR.
  • I have ensured that I did not break any existing API calls.
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight.

Copy link

netlify bot commented Aug 12, 2024

Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit 09e8e02
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/671674b8bdab330008f9658e
😎 Deploy Preview https://deploy-preview-1223--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added documentation Improvements or additions to documentation code Improvements or additions to code. labels Aug 12, 2024
@ruslan-ilesik
Copy link
Contributor

I believe you should cover this feature with unit tests. (Look how other "online" tests are made for similar things)

@Mishura4
Copy link
Member

Try using DPP_DEPRECATED instead of [[deprecated]] to fix those errors on windows

@braindigitalis
Copy link
Contributor

@raxyte any movement on this pr, or is it dead?

@raxyte
Copy link
Contributor Author

raxyte commented Oct 8, 2024

Don't have time to get back to it. Can close if no one else can take over it.

@Jaskowicz1
Copy link
Contributor

I can try take over :)

@braindigitalis
Copy link
Contributor

if theres no movement on this, i'm happy to take it on?

@Jaskowicz1
Copy link
Contributor

Jaskowicz1 commented Oct 21, 2024 via email

@braindigitalis braindigitalis changed the base branch from dev to userapps October 21, 2024 15:36
@braindigitalis braindigitalis marked this pull request as ready for review October 21, 2024 15:36
@braindigitalis braindigitalis merged commit 7a0e5f2 into brainboxdotcc:userapps Oct 21, 2024
35 of 49 checks passed
@braindigitalis
Copy link
Contributor

i have merged this into a branch on the dpp main repo called userapps and will continue to work on it. This has been done without rebase, so that credit for existing work is preserved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code Improvements or additions to code. documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants