[Feature] PopupBridge++ by jtanya17 · Pull Request #90 · braintree/popup-bridge-ios

jtanya17 · 2026-03-20T17:55:58Z

Summary of changes

Add PayPal app switch support to PopupBridge
Introduces an optional enablePopupBridgeAppSwitch flag to POPPopupBridge that, when enabled, allows the SDK to launch the native PayPal app for checkout instead of opening a browser session.
When the app launch succeeds, a NotificationCenter observer handles the deep link return URL and injects the result back into the WebView. If the app launch fails, the flow falls back to the existing WebAuthenticationSession behavior.
Exposes isPayPalInstalled, launchApp(), and getDeepLinkReturnUrlPrefix() to JavaScript, and fires analytics events for app detection and launch outcomes.

Checklist

Added a changelog entry

Authors

List GitHub usernames for everyone who contributed to this pull request.

@jtanya17

Add app switch toggle for backwards compatibility

jaxdesmarais · 2026-04-07T20:18:01Z

+    ///   instead of opening a browser. Defaults to false for backward compatibility.
+    ///   This is specific to the popup bridge flow and is separate from the JS SDK's
+    ///   appSwitchWhenAvailable which controls non-webview mobile browser app switch.
+    public init(webView: WKWebView, prefersEphemeralWebBrowserSession: Bool = true, enablePopupBridgeAppSwitch: Bool = false) {


why does this take a different approach vs venmo?

This PR follows the existing Popup Bridge pattern and only adds PayPal-specific app-switch handling behind the feature flag. I kept Venmo unchanged here to avoid expanding scope, since the HLD and QA for this work were focused on the PayPal path.

jaxdesmarais · 2026-04-07T20:19:52Z

+            guard let self,
+                  let url = notification.userInfo?["url"] as? URL else {


Suggested change

guard let self,

let url = notification.userInfo?["url"] as? URL else {

guard let self, let url = notification.userInfo?["url"] as? URL else {

What if self is nil here?

Hey Jax, if self is nil, the bridge has already been deallocated and there’s nothing left to handle, so returning early is the correct behavior. I split the guards to make that explicit.

jaxdesmarais · 2026-04-07T20:26:38Z

+
+        if let returnUrlScheme {
+            let deepLinkReturnUrlPrefix = "\(returnUrlScheme)://\(host)/"
+            deepLinkJs = """


What does deepLinkJs mean/do?

deepLinkJs injects the getDeepLinkReturnUrlPrefix() JavaScript function onto window.popupBridge

jaxdesmarais · 2026-04-07T20:26:50Z

+                            return '\(deepLinkReturnUrlPrefix)';
+                        };
+            """
+            deepLinkProperty = """


What does deepLinkProperty mean/do?

deepLinkProperty injects the deepLinkReturnUrlPrefix JavaScript property onto window.popupBridge

buzzamus

It doesn't appear this PR builds. Looks like there are issues around launchAppReturnObserver. Once this builds and has been thoroughly tested please let us know when this is ready for review

buzzamus · 2026-05-05T15:01:24Z

+            Self.analyticsService.sendAnalyticsEvent(PopupBridgeAnalytics.succeeded, sessionID: sessionID)
+
+            let script = """
+                ;(function() {


I am assuming there is a specific reason this starts with a semicolon, but I am just curious what the reason is

- Add missing convenience init - Fix compiler error - Fix failing test - Add code comment explaining the leading semicolon - Add `## unreleased` CHANGELOG entry for `enablePopupBridgeAppSwitch` and new JS APIs

* docs: create SECURITY.md * docs: update SECURITY.md

* Add integration test coverage

buzzamus

I think the git history got messed up somewhere since it has previous PR changes as part of this PR's commit history and also left a few other comments.

buzzamus · 2026-05-07T17:51:01Z

 > List GitHub usernames for everyone who contributed to this pull request.
-
- 
+-


I don't think this file is from this PR. I see several files committed from previous PRs, so I think your git history is screwed up somehow.

buzzamus · 2026-05-07T17:51:57Z

+      codeCoverageEnabled = "YES">
      <Testables>
         <TestableReference
            skipped = "NO">


Same here. I don't think this change is meant for this PR as it was already merged into main

buzzamus · 2026-05-07T17:52:47Z

+        get { stubBody }
+        set { stubBody = newValue }
+    }
+}


Same with this file. This is already merged into main

buzzamus · 2026-05-07T17:52:55Z

+        startWasCalled = true
+        capturedURL = url
+    }
+}


buzzamus · 2026-05-07T17:53:49Z

+    }
+
+    override func stopLoading() {}
+}


buzzamus · 2026-05-07T17:54:48Z

@@ -0,0 +1,145 @@
+import AuthenticationServices


buzzamus · 2026-05-07T17:54:57Z

@@ -0,0 +1,53 @@
+<?xml version="1.0" encoding="UTF-8"?>


buzzamus · 2026-05-07T17:56:47Z

+		085C05B32F9A78E000460CD9 /* MockWebAuthSession.swift in Sources */ = {isa = PBXBuildFile; fileRef = 085C05B22F9A78E000460CD9 /* MockWebAuthSession.swift */; };
+		085C05B82F9A79DA00460CD9 /* MockScriptMessage.swift in Sources */ = {isa = PBXBuildFile; fileRef = 085C05B72F9A79DA00460CD9 /* MockScriptMessage.swift */; };
+		085C05BA2F9A7AB900460CD9 /* StubURLProtocol.swift in Sources */ = {isa = PBXBuildFile; fileRef = 085C05B92F9A7AB900460CD9 /* StubURLProtocol.swift */; };
 		451348272D8CAD7C009265C9 /* WebViewScriptHandler.swift in Sources */ = {isa = PBXBuildFile; fileRef = 451348262D8CAD6D009265C9 /* WebViewScriptHandler.swift */; };


This project file has all of the changes from recent PRs in it, so this will also need to be resolved. Not sure if this is from a bad merge or a rebase screwed up the history, but these need to be removed. The best way will be to instead of manually removing see if you can fix the git history

buzzamus · 2026-05-07T17:58:51Z

+- Avoid accessing, modifying, or deleting data that does not belong to you
+- Make a good faith effort to avoid disruption to production systems
+
+We appreciate responsible disclosure and your efforts to keep Braintree SDK users safe.


This is another previously merged change

buzzamus · 2026-05-07T18:11:02Z

+
+    /// Exposed for testing
+    convenience init(
+        webView: WKWebView,


There are quite a few initializers now in this file, which to me is a big code smell. I think we should try and find a different way to handle. If we are using default values this wouldn't be a breaking change so, I am not sure if we need so many new ones created

jaxdesmarais · 2026-05-07T18:17:04Z

@jtanya17 I am moving this PR to a draft state based on @buzzamus comments as this code is not ready to be reviewed by my team. Please resolve our issues and take a look through your diff before reopening.

jtanya17 · 2026-05-15T16:59:49Z

Closing in favor of #95

Tanya Jain and others added 7 commits March 9, 2026 16:47

Enhanced popup bridge

1a97880

Add tests

2223179

Configure returnUrlScheme

3169fef

add cancel path and fix return

bd2ada2

Remove fragment logic

f6528c7

Add app switch toggle for backwards compatibility

8a4a025

Merge pull request #1 from naderchehab/feature/enhanced-popup-bridge

7f2c8da

Add app switch toggle for backwards compatibility

jtanya17 changed the title ~~Feature/enhanced popup bridge~~ [Feature] PopupBridge++ Mar 23, 2026

Tanya Jain added 3 commits March 23, 2026 11:59

Remove logs

7dc34ea

clean up

20f8d2c

Clean up white spaces

c6f636c

jaxdesmarais reviewed Apr 7, 2026

View reviewed changes

Tanya Jain added 5 commits April 21, 2026 07:44

Address review comments

8f2daf5

restore var names

9e1930f

Fix casing

fd8473d

Update formatting

754a779

remove extraneous var

bcb7c3c

jtanya17 marked this pull request as ready for review April 28, 2026 16:01

jtanya17 requested a review from a team April 28, 2026 16:01

jtanya17 requested a review from a team as a code owner April 28, 2026 16:01

NastassiaRodzik approved these changes Apr 29, 2026

View reviewed changes

buzzamus requested changes May 5, 2026

View reviewed changes

vkspune and others added 5 commits May 7, 2026 09:47

Fix build failures and test issues for app switch feature

071e895

- Add missing convenience init - Fix compiler error - Fix failing test - Add code comment explaining the leading semicolon - Add `## unreleased` CHANGELOG entry for `enablePopupBridgeAppSwitch` and new JS APIs

update pr template to include ai usage (braintree#91)

031db2f

Add SECURITY.md (braintree#92)

761248f

* docs: create SECURITY.md * docs: update SECURITY.md

Add integration test coverage (braintree#93)

9fa631e

* Add integration test coverage

Update build.yml

2cd66fc

buzzamus requested changes May 7, 2026

View reviewed changes

jaxdesmarais marked this pull request as draft May 7, 2026 18:17

joaaraujo-paypal mentioned this pull request May 13, 2026

Feature/popupbridge #95

Open

jtanya17 closed this May 15, 2026

		guard let self,
		let url = notification.userInfo?["url"] as? URL else {

	guard let self,
	let url = notification.userInfo?["url"] as? URL else {
	guard let self, let url = notification.userInfo?["url"] as? URL else {

Conversation

jtanya17 commented Mar 20, 2026 • edited by jaxdesmarais Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary of changes

Checklist

Authors

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

buzzamus left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

buzzamus left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jaxdesmarais commented May 7, 2026

Uh oh!

jtanya17 commented May 15, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

jtanya17 commented Mar 20, 2026 •

edited by jaxdesmarais

Loading