Fix attribute filters with quoted attribute names#590
Open
fresh3nough wants to merge 1 commit intobrave:masterfrom
Open
Fix attribute filters with quoted attribute names#590fresh3nough wants to merge 1 commit intobrave:masterfrom
fresh3nough wants to merge 1 commit intobrave:masterfrom
Conversation
ABP-style attribute selectors use quoted attribute names like: div["data-apiary-widget-name"*="value"] This is not valid CSS syntax. Standard CSS requires: div[data-apiary-widget-name*="value"] The fix normalizes ABP syntax to standard CSS by removing quotes around attribute names before CSS validation. This allows filters from Adblock Plus to work correctly in adblock-rust. Fixes brave#438
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ABP-style attribute selectors use quoted attribute names like:
div["data-apiary-widget-name"*="value"]
This is not valid CSS syntax. Standard CSS requires:
div[data-apiary-widget-name*="value"]
The fix normalizes ABP syntax to standard CSS by removing quotes around attribute names before CSS validation. This allows filters from Adblock Plus to work correctly in adblock-rust.
Fixes #438