Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove line from "Delete site data?" modal that is not applicable #42301

Open
3 of 6 tasks
LaurenWags opened this issue Nov 14, 2024 · 0 comments · May be fixed by brave/brave-core#26554
Open
3 of 6 tasks

Remove line from "Delete site data?" modal that is not applicable #42301

LaurenWags opened this issue Nov 14, 2024 · 0 comments · May be fixed by brave/brave-core#26554

Comments

@LaurenWags
Copy link
Member

Description

When clearing data from the site details page of settings, there's a line that says "Data that affects ad personalization is deleted". This comes from Chromium and Brave Ads does not factor in - since it's not applicable to Brave Ads this line should be removed.

Steps to reproduce

  1. Clean profile (either 1.71.123 with C130 or 1.73.89 with C131)
  2. Close/relaunch to pull griffin
  3. Navigate to a site (ex. https://www.whatarecookies.com/cookietest.asp)
  4. After site loads, click on the "tune" icon in the URL bar and select "Site settings"
  5. Click the "Delete data" button
  6. See modal

Actual result

Image

Expected result

last line of modal should be removed

Reproduces how often

Easily reproduced

Brave version (brave://version info)

1.71.123 Chromium: 130.0.6723.116 and 1.73.89 Chromium: 131.0.6778.69

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

See discussion via https://bravesoftware.slack.com/archives/CJR5902AW/p1731596872669909

cc @iambrianfung @rebron @brave/qa-team

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

1 participant