Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SiteSettings] Remove non-applicable info when deleting site data. #26554

Merged

Conversation

jagadeshjai
Copy link
Collaborator

Resolves brave/brave-browser#42301

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@jagadeshjai jagadeshjai force-pushed the fix_remove_ad_personalization_info branch from 592b1b7 to d0fafa0 Compare November 15, 2024 01:54
@jagadeshjai jagadeshjai marked this pull request as ready for review November 15, 2024 01:55
@jagadeshjai
Copy link
Collaborator Author

jagadeshjai commented Nov 15, 2024

@bsclifton Please take a look, got all Greens!

@bsclifton
Copy link
Member

Admin merging as CI passed with #26577

@bsclifton bsclifton merged commit ee88399 into brave:master Nov 18, 2024
5 of 7 checks passed
@brave-builds
Copy link
Collaborator

Released in v1.75.27

@jagadeshjai jagadeshjai deleted the fix_remove_ad_personalization_info branch November 18, 2024 16:53
@jagadeshjai
Copy link
Collaborator Author

Thanks for merging @bsclifton !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove line from "Delete site data?" modal that is not applicable
4 participants